Describe the bug
When using monks-combat-details placeholders in the initiative tracker with (for example) earthdawn4e an error message appears, no initiative for the placeholder is rolled and the combat tracker does not advance to the next round (it's always round 1).
Console message:
Uncaught (in promise) TypeError: CONFIG.Dice.D20Roll is not a constructor
CombatantInitiative https://[my url]/modules/monks-combat-details/js/placeholder.js:48
[...]
To Reproduce
Steps to reproduce the behavior:
install earthdawn4e as system
create a combat encounter with a placeholder and start the encounter
advance through the turns to the end of the round and begin next round,
Earthdawn system initiates initiative roll at start of new round
See error in console and still round 1 in combat tracker
Expected behavior
Combat tracker increments round number by one.
Desired behavior
Desired behavior is hard to pin down. In general different systems use different ways to generate initiative, I recognize there is no easy one-size-fits-all solution, but the solution implemented right now is either only compatible with D20 systems or uses deprecated CONFIG elements.
There should be a way to "keep last rounds initiative value" for placeholders or a way to input a formula like 1d20 or 1d8x or 20 and roll that without the CONFIG.Dice.D20Roll constructor.
Quick fix
In /js/placeholder.js:48 use a different way to roll a D20, like ~return new CONFIG.Dice.D20Roll("1d20", {});~ -> return new CONFIG.Dice.rolls[0]("1d20", {});, but this seems like a really dirty solution.
Please complete as much of the following information as possible:
Browser: Firefox for Linux Mint v124.02 (64 Bit)
Foundry Version: v11 build 315
System: earthdawn4e
Module version: 11.15
Are there any errors in the console: see above
Find the Culprit: Yes, Find the Culprit has identified monks-combat-details as the culprit.
Describe the bug When using monks-combat-details placeholders in the initiative tracker with (for example) earthdawn4e an error message appears, no initiative for the placeholder is rolled and the combat tracker does not advance to the next round (it's always round 1).
Console message:
To Reproduce Steps to reproduce the behavior:
Expected behavior Combat tracker increments round number by one.
Desired behavior Desired behavior is hard to pin down. In general different systems use different ways to generate initiative, I recognize there is no easy one-size-fits-all solution, but the solution implemented right now is either only compatible with D20 systems or uses deprecated CONFIG elements. There should be a way to "keep last rounds initiative value" for placeholders or a way to input a formula like
1d20or1d8xor20and roll that without the CONFIG.Dice.D20Roll constructor.Quick fix In
/js/placeholder.js:48use a different way to roll a D20, like ~return new CONFIG.Dice.D20Roll("1d20", {});~ ->return new CONFIG.Dice.rolls[0]("1d20", {});, but this seems like a really dirty solution.Please complete as much of the following information as possible:
Find the Culprit: Yes,Find the Culprithas identifiedmonks-combat-detailsas the culprit.