ironmonk88 / monks-combat-details

GNU General Public License v3.0
11 stars 7 forks source link

[BUG] Placeholder breaks the group from Combat Tracker Extensions module #82

Open stalker168 opened 4 months ago

stalker168 commented 4 months ago

Describe the bug There is a Combat Tracker Extensions module that allows you to do group initiative in the DnD5 system. But if you add a placeholder combatant to the initiative, groups break. The settings button for the Combat Tracker Extensions module disappears. All groups below the combatant's initiative are broken. When the combatant is removed, everything returns to its place.

Console error after adding a combatant:

combat-tracker-extensions.js:563  Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'innerHTML')
    at Object.fn (combat-tracker-extensions.js:563:32)

Before adding a combatant image After adding a combatant image

image

To Reproduce Steps to reproduce the behavior:

  1. Create a fight
  2. Add Placeholder Combatant
  3. See error

Expected behavior Using the Combat Enhancements module in conjunction with Combat Tracker Extensions shows that the group can adjust to changes in the initiative's turn. From this I can conclude that it is possible to add a combatant without breaking groups. After adding a combatant, the groups will adjust to the new participant, preserving their integrity.

Screenshots If applicable, add screenshots to help explain your problem.

Please complete as much of the following information as possible: