ironmonk88 / monks-common-display

GNU General Public License v3.0
19 stars 5 forks source link

[BUG] Compatiblity Issues Between MEJ, Common Display and Storyteller Modules #56

Closed davidhawbecker closed 9 months ago

davidhawbecker commented 9 months ago

Describe the bug

I use Common Display for in person gaming with a laptop running the Foundry application for the GM Screen and a flat touch screen TV for the player view. When using MEJ, Storyteller and Common Display together, if I create a Journal using one of the Storyteller Templates is causes some problems. Namely when you try to show players a StoryTeller journal entry it will not show on the player screen when Common Display is enable with GM view/control. Then there are host of other bugs that occur when you use any of the StoryTeller addon single sheets.

To Reproduce Steps to reproduce the behavior:

  1. Run two instances of Foundry, one in the Native Application (GM View) and one in a Browser (Chrome or Edge) for the Player View.
  2. Enable Common Display and set screen mirror and control to "GM"
  3. Create a Journal Entry and select type "StorySheet"
  4. Open the new Journal Entry
  5. StorySheet Journal Entry should open (looks like and open book).
  6. Select Show Players.
  7. Observe the Player view in the browser instance of Foundry. Nothing shows up.
  8. Disable Common Display and you will see the StorySheet journal entry on the player screen. However this defeats the purpose of having Common Display active to control the players screen.

Even more problems occur if you use any of the Storyteller addon singlesheets (v1.2.2). If you use these it actually breaks MEJ and will occasionally prevent you from closing the Enhanced Journal window. You have to restart Foundry.

Expected behavior Reveal the Storyteller Journal entries to players when you Show Players while using Common Display in GM view.

Screenshots If applicable, add screenshots to help explain your problem.

Please complete as much of the following information as possible:

Additional context I realize this may to be niche to spend time on, but if it's of interest to others to be able to have StoryTeller functionality with MEJ and Common Display, I am happy to help troubleshoot this further. Again, I clearly love Monk's stuff (see above) and for the most part it does every thing I need, but the StoryTeller module asthetics are such a nice addition to the way I can show player handouts for various things from Books to Documents. If it's it's feasible and makes sense let me know. Like I said, I'm happy to test. Thank you as always for all of your work.

ironmonk88 commented 9 months ago

Storyteller compatibility added to 11.07