ironmonk88 / monks-enhanced-journal

GNU General Public License v3.0
53 stars 54 forks source link

[Request/Issue] Game system icons are bypassed #199

Closed Gardakan93 closed 1 year ago

Gardakan93 commented 2 years ago

Hi !

Special characters provided by some game system, like dice symbol in FFG systems are override by the module. If the journal entry was created without the module, the module keep displaying theses icons, but if we edit the journal entry or try to create a new one with special characters, it won't recognize it.

Is it possible to fix ?

Thank you for your great work !

ironmonk88 commented 2 years ago

Can you show me a screen shot of how you get the special characters?

Gardakan93 commented 2 years ago

Here is a screenshot of L5R special characters syntaxe with your module (icon doesn't appear) image

Here is a screenshot of the same characters without your module (wich display icons) image

You can find on the french wiki of L5R for foundry the detail of all special characters. Here's a screenshot : image

This is similar to special characters for star wars ffg system (which works with your module).

ironmonk88 commented 2 years ago

Okay, I've looked into this extensively..., and... I don't think I can fix it. At least not easily. The problem is, that L5R is using a really weird way to try and add these symbols, by converting to text before editing, and then back on saving. Core Foundry uses a function called enrichHTML which is used to add symbols like this that doesn't affect the saving of the text. I think this should really go back to the developers of the system to use the Foundry method for displaying the symbols instead. It would avoid confusion and would be a little more stable than what they're currently using. That's just my opinion... but for me to make it work I'd have to jump through a lot of hoops. If you contact them and they absolutely refuse to do it that way... please let me know and I'll revisit this and try and put something together.

ironmonk88 commented 1 year ago

Closing this as it seems to be working now.