ironmonk88 / monks-enhanced-journal

GNU General Public License v3.0
53 stars 54 forks source link

[BUG] Checkbox "Show to players" not work properly #608

Closed kai-nashi closed 1 year ago

kai-nashi commented 1 year ago

Describe the bug Quest type of journal. Checkbox "Show to players" not work properly. If you want to show it to players you must set checked "Show to players" and then uncheck and check again "Display in notification". To hide quest from players objectives list all steps is same.

To Reproduce Steps to reproduce the behavior:

  1. Create any journal with quest type
  2. Set checked "Display in notification"
  3. Join to game as user in private tab of browser
  4. As player you see objectives list is empty - correct
  5. As GM: for quest check "Show to players"
  6. As player: you don't see new quest
  7. As GM: uncheck and check "Display in notification" ("Show to players" still checked and hasn't touched)
  8. As player: new quest is showing

Expected behavior Checking "Show to players" should instantly show quest's in player's objectives list.

Screenshots

Please complete as much of the following information as possible:

Additional context

ironmonk88 commented 1 year ago

That was just an issue refreshing the notifications list. The show button was acting correctly. Fixed in the latest release