ironmonk88 / monks-enhanced-journal

GNU General Public License v3.0
51 stars 51 forks source link

[BUG] Changing sheet via sheet settings not possible #685

Closed ZeroXNoxus closed 4 months ago

ZeroXNoxus commented 5 months ago

Describe the bug Changing the actor sheet via the sheet setting in the dragable header will not change the sheet configuration. It just loads the v2 sheet and the setting to e.g. Legacy Sheet is not saved:

Current Settings: image

Attempted Change: image

Result Settings after save: image

The only change applied to these settings is via the Game Configurations. This issue seems to only apply when the v2 sheet is currently set for the to-be changed sheet.

I have already run through my 80+ modules and only "Monk's Enhanced Journal" causes this issue on DnD 5th Edition v3.1.X

To Reproduce Steps to reproduce the behavior:

  1. Enable "Monk's Enhanced Journal"
  2. Open character sheet
  3. Attempt to change from DnD 5th Edition Sheet v2 to any other sheet
  4. See error

Please complete as much of the following information as possible:

hatakemaara commented 5 months ago

I came here to report this bug as I am also experiencing it as the DM and my players get it as well on their browsers.

As a workaround, I disable "Monk's Enhanced Journal" so my players can change their sheet and then when I renable the module it remembers the sheet change (in this case they want to use the "Tidy 5e sheet" module). However, if they change back to the "default 5e sheet" the bug occurs again, and they can't switch back to the "legacy sheet" or any custom sheets.

Browser: Firefox Foundry Version: v11.315 System D&D 5E v3.1.1 Module v11.10

YenBenGrey commented 5 months ago

I am also getting this problem, same set up as the OP. Following.

Dyrnwyrm commented 4 months ago

Same issue here, cant change sheets, tested with tidy sheet, disabling the module fixes the issue

ironmonk88 commented 4 months ago

Should be fixed in the latest version