ironmonk88 / monks-enhanced-journal

GNU General Public License v3.0
51 stars 51 forks source link

[BUG] Currency not converting in shop #706

Open ashort3821 opened 2 months ago

ashort3821 commented 2 months ago

Describe the bug When attempting to use the "convert" button in a shop while in PF2e and in Forge, the currency remains on silver, gold, platinum, etc. and will not convert down. For example, an item with worth 1 gold when sold in a shop for 1.01 will convert to 2 gold instead of 101 copper. It seems to instead round up that currency. I have settings on for currency conversion.

To Reproduce Steps to reproduce the behavior:

  1. Be on a Forge server.
  2. Pull an item from compendium or generate one using a list.
  3. Adjust sell price to make sure that it should convert to another currency.
  4. See price change.

Note: Surprisingly, there is no error code I could see. I also have the settings turned on so conversion should work properly.

Expected behavior Currency should convert down to lower currencies to reflect shop's personal prices.

Screenshots Screenshot 2024-06-25 150935

Screenshot 2024-06-25 151217

Please complete as much of the following information as possible:

Additional context If you need any other additional information, please let me know.

ashort3821 commented 2 months ago

Additional information: This specifically seems to be targeting the "Adjust All Prices" button and not the actual page settings. So there is a work around for now.