search

ironmonk88 / monks-enhanced-journal

GNU General Public License v3.0
52 stars 53 forks source link

[BUG] Conflicts with kanka-Foundry #717

Open eXaminator opened 1 month ago

eXaminator commented 1 month ago

Hi, I'm the maintainer of the Kanka-Foundry module (https://github.com/eXaminator/kanka-foundry).

I received a conflict bug (https://github.com/eXaminator/kanka-foundry/issues/140) but was able to trace it back to your module.

It seems that you - for some reason - make a copy of foundries JournalEntryPage dataTypes using foundry.utils.mergeObject(). The problem here is, that this function seems to handle object property keys with points in them (like kanka-foundry.abilities) by creating nested objects (like { 'kanka-foundry': { 'abilities': ... } }). Once this happens, it breaks other stuff in foundry down the line as foundry expects dataTypes to be a simple (flat) key-value map of schemas.

Here's the line: https://github.com/ironmonk88/monks-enhanced-journal/blob/a811fcdf1ae5d9d5d699cf1f9984ffec2a68bc89/monks-enhanced-journal.js#L2113

Is there a specific reason for this call? Could it be done another way as to prevent breaking other modules that use dots no namespace their dataType names?

Thanks!

Nedrapter commented 1 month ago

I've been a victim of this conflict and it makes the world not able to load anymore! Please fix! I love both modules!