ironmonk88 / monks-enhanced-journal

GNU General Public License v3.0
52 stars 53 forks source link

[BUG] Localization error causes foundry to crash when loading "new" module I am trying to dev #720

Open jfrazierjr opened 1 month ago

jfrazierjr commented 1 month ago

Describe the bug This COULD very well be a bug in MY code, I am new to JS(but not to programming in general) and trying a very simple module example from the foundry wiki with a few changes. The same happens when following step by step with the example on the linked page below.

To Reproduce Steps to reproduce the behavior:

  1. Add Module that uses Journal Page sub types as explained HERE (as suggested by Core Foundry discord team to add subtypes to the base ones)
  2. Add Enhanced Journal
  3. reload/refresh

Expected behavior Both modules load and play nice together. This could be a core foundry issue where they don't expect referedering of already rendered core elements(I doubt that though) or it could very well be I am missing something. I did attempt a bit of help from the Foundry core discord and they suggested I added LOCALIZATION_PREFIXES to my Model which I did(not sure if done correctly or not though)

For reference, my module is uploaded(no release, just raw files): https://github.com/jfrazierjr/fantasybookjournal Call to Localization.#localizeDataModels(); throws exception and locks client(ie, game does not load).

Screenshots image

And THIS is right before the exception is thrown in the #localizeSchema method. Note the current model is an object.bookpage with LOCALIZATION_PREFIXES. image

image

Please complete as much of the following information as possible:

Additional context Add any other context about the problem here.

jfrazierjr commented 5 days ago

Appears to be duplicate for https://github.com/ironmonk88/monks-enhanced-journal/issues/717