search

ironmonk88 / monks-little-details

GNU General Public License v3.0
33 stars 36 forks source link

Collapse / expand button disappear with module activate on WFRP 4e #55

Closed alexremy closed 3 years ago

alexremy commented 3 years ago

When module is activated, and if the sidebar is collapsed, the button to re-expand has disappeared. I desactivated all modules except Monk's Little Details and had 100% reproduction of the issue. When module is uninstalled, the issue disappears.

ironmonk88 commented 3 years ago

Did that just start? Or has that been a thing for awhile. Little Details shifts the button up to the top, so if you accidentally collapse the sidebar you don't have to move your mouse down to expand it again, the button is right where the collapse button was. It looks like warhammer is doing some really weird styling on those buttons, that doesn't entirely make sense. And I was wondering if the developers of the system introduced an issue. I've corrected the code on my end so that warhammer should appear correctly, but if the developers didn't intend their changes and fix it, the button will disappear again.

Fix should appear in the next release.

alexremy commented 3 years ago

Thanks for getting back to me this quick, really appreciated! It started weeks ago, and I'm assuming it was right when I installed Monk's the first time, but I did noticed yet. I kept living with the issue as refreshing page make the sidebar re-expand by default. I'm attaching two screenshots (collapsed & expanded) to show you what I am getting in terms of display. I took them right this minute with Monk's installed (and same again, the issue is not here when the module is uninstalled).

collapsed expanded

ironmonk88 commented 3 years ago

Should be fixed now. Latest release is out.

alexremy commented 3 years ago

Thanks very much!