Open xKillerbees opened 9 months ago
Confirming that Dorako UI and Doraku UX do not work with Sync Settings. They only save locally and do not update.
I connected with a PC while having the same issue with Doraku UX - found that the player was getting this error when All Players configuration was being saved in the GM settings:
commons.js:2572 Uncaught (in promise) TypeError: Cannot create property 'no-cards' on string '[object Object]'
at setProperty (commons.js:2572:19)
at _expand (commons.js:2337:9)
at expandObject (commons.js:2341:12)
at MonksPlayerSettings.checkSettings (monks-player-settings.js:229:63)
at MonksPlayerSettings.ready (monks-player-settings.js:57:29)
at Object.fn (monks-player-settings.js:384:25)
at #call (foundry.js:730:20)
at Hooks.callAll (foundry.js:687:17)
at Game.setupGame (foundry.js:8746:11)
at async Game._initializeGameView (foundry.js:9990:5)
at async Game.initialize (foundry.js:8650:5)
I assume it's getting hung up on the Hide Cards Tab setting? I've found this typeError on a few other modules so far.
This is still in v11 for me, though.
It looks like this problem is coming up with multiple add-ons for different settings where maybe the type parsing is off?
Basically I've found multiple modules that it doesn't record / sync settings and all them have different property names (i.e. no-cards in this example) but the problem is that they are all saying that they cannot create property on string [object Object]
It took me a hot minute to notice that the property name sometimes was different after I made this bug. I'll try to collect some more of the errors and their source module names for additional reference.
From what I'm seeing, it seems like the problem is where some modules have this type of setting that isn't correctly handled so hopefully it's one bug fix for all the modules rather than a module-specific issue as I thought it was originally.
Describe the bug When making adjustments for [All] or an individual player, settings changed within the module are not saved and reset to default
To Reproduce Steps to reproduce the behavior:
Expected behavior The settings I update within PF2E Dorako to update as I set defaults and it maintains them
Please complete as much of the following information as possible: