ironmonk88 / monks-tokenbar

GNU General Public License v3.0
48 stars 44 forks source link

[BUG] PF2e Perception Skill Doesn't Work With "Request For Roll" Feature #379

Closed josh-koonce closed 1 year ago

josh-koonce commented 1 year ago

Describe the bug When using the "Request a Roll" feature, it works normally in PF2e EXCEPT for Perception, where it reports "Could Not Find Function to Roll". All other attributes and skills seem to work normally.

To Reproduce Steps to reproduce the behavior:

  1. Press Alt-Shift-R to request a roll from a token player
  2. Use Perception
  3. Send the request with roll
  4. See the error

Expected behavior A Perception roll to happen.

Please complete as much of the following information as possible:

Silvertower commented 1 year ago

This happens with module version 11.01 as well.

josh-koonce commented 1 year ago

True. I upgraded and tried it today and can confirm. Really hoping for a quick fix on this because I'm trying so hard to be a good GM and actually roll secret Perception checks to not give away secrets haha.

this-gavagai commented 1 year ago

At some point, the location of the SimpleStatistic object for the Perception attribute changed on the actor. I've made a PR with working code.

josh-koonce commented 1 year ago

Thank you so much! God bless coders!