ironmonk88 / monks-tokenbar

GNU General Public License v3.0
47 stars 44 forks source link

Request Roll and Contested Roll not working #468

Open nuck1234 opened 6 months ago

nuck1234 commented 6 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behaviour:

  1. Go to 'Select Request a Roll' and complete the fields as required.

    Screenshot 2024-03-04 at 14 30 37
  2. Click on 'Request with Roll'

  3. See error

    Screenshot 2024-03-04 at 14 31 03
Screenshot 2024-03-04 at 14 31 17
  1. The same thing occurs in Contested Roll.

Expected behavior The roll should happen

Please complete as much of the following information as possible:

Are there any errors in the console? See attached log from console.

Screenshot 2024-03-04 at 14 32 41

Have you tried using Find the Culprit to make sure it isn't a module interaction? Yes.

Additional context

benjamin-ping-xu commented 6 months ago

I'm having the same issue. To add on some information, there are 4 interactions I've tested:

Button Mode Working?
Request Roll Request Yes
Request with Roll No
Contested Roll Request No
Request with Roll No

For Request Roll (Request with Roll), the error message is as provided by nuck1234.

For Contested Roll (Request, Request with Roll), the error message is different. See below.

Contested Roll (Request)

chat-message.mjs:251 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'formula')
    at ChatMessage5e._enrichRollTooltip (chat-message.mjs:251:54)
    at chat-message.mjs:233:51
    at NodeList.forEach (<anonymous>)
    at ChatMessage5e._enrichChatCard (chat-message.mjs:232:46)
    at ChatMessage5e.getHTML (chat-message.mjs:58:10)
    at async ChatLog.postOne (foundry.js:85744:18)

Contested Roll (Request with Roll)

chat-message.mjs:251 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'formula')
    at ChatMessage5e._enrichRollTooltip (chat-message.mjs:251:54)
    at chat-message.mjs:233:51
    at NodeList.forEach (<anonymous>)
    at ChatMessage5e._enrichChatCard (chat-message.mjs:232:46)
    at ChatMessage5e.getHTML (chat-message.mjs:58:10)
    at async ChatLog.postOne (foundry.js:85744:18)
    at async ChatLog.updateMessage (foundry.js:85808:7)
ironmonk88 commented 6 months ago

Duplicate of #467

nuck1234 commented 6 months ago

Thank you for pointing it out. I was not sure if it was or not. I think bejamin provided the rest of the detail I missed.