ironmonk88 / monks-tokenbar

GNU General Public License v3.0
48 stars 46 forks source link

Rolls not being revealed with Dice So Nice is active but not enabled. #494

Open tposney opened 4 months ago

tposney commented 4 months ago

In foundry v11/v12 and dnd5e 3.2 (but not relevant).

When monks tests to reveal a roll it uses

const revealDice = game.dice3d ? game.settings.get("dice-so-nice", "immediatelyDisplayChatMessages") : true;

which causes a problem when dice so nice is active but not enabled. All of the revealDice tests could be replaced with

const revealDice = game.dice3d ? (game.settings.get("dice-so-nice", "immediatelyDisplayChatMessages") || !game.dice3d.isEnabled()) : true;

which will reveal the roll as required.