ironmonk88 / monks-tokenbar

GNU General Public License v3.0
47 stars 44 forks source link

Fix PF2e 6.1.0+ update compatibility #504

Closed dslogget closed 1 month ago

dslogget commented 1 month ago

Seems like pf2e has changed the skill list from "skillList" to "skills"

I manually tested this and this one change seems to have helped on first glance

dslogget commented 1 month ago

this seems to be what causes issue #503

dslogget commented 1 month ago

I see now that some more things have changed and this was a naive change that would need more work to be mergable

skillList:

{
    "acrobatics": "PF2E.Skill.Acrobatics",
    "arcana": "PF2E.Skill.Arcana",
    "athletics": "PF2E.Skill.Athletics",
    "crafting": "PF2E.Skill.Crafting",
    "deception": "PF2E.Skill.Deception",
    "diplomacy": "PF2E.Skill.Diplomacy",
    "intimidation": "PF2E.Skill.Intimidation",
    "medicine": "PF2E.Skill.Medicine",
    "nature": "PF2E.Skill.Nature",
    "occultism": "PF2E.Skill.Occultism",
    "performance": "PF2E.Skill.Performance",
    "religion": "PF2E.Skill.Religion",
    "society": "PF2E.Skill.Society",
    "stealth": "PF2E.Skill.Stealth",
    "survival": "PF2E.Skill.Survival",
    "thievery": "PF2E.Skill.Thievery",
    "lore": "PF2E.SkillLore"
}

vs

skills:

{
    "acrobatics": {
        "label": "PF2E.Skill.Acrobatics",
        "attribute": "dex"
    },
    "arcana": {
        "label": "PF2E.Skill.Arcana",
        "attribute": "int"
    },
    "athletics": {
        "label": "PF2E.Skill.Athletics",
        "attribute": "str"
    },
    "crafting": {
        "label": "PF2E.Skill.Crafting",
        "attribute": "int"
    },
    "deception": {
        "label": "PF2E.Skill.Deception",
        "attribute": "cha"
    },
    "diplomacy": {
        "label": "PF2E.Skill.Diplomacy",
        "attribute": "cha"
    },
    "intimidation": {
        "label": "PF2E.Skill.Intimidation",
        "attribute": "cha"
    },
    "medicine": {
        "label": "PF2E.Skill.Medicine",
        "attribute": "wis"
    },
    "nature": {
        "label": "PF2E.Skill.Nature",
        "attribute": "wis"
    },
    "occultism": {
        "label": "PF2E.Skill.Occultism",
        "attribute": "int"
    },
    "performance": {
        "label": "PF2E.Skill.Performance",
        "attribute": "cha"
    },
    "religion": {
        "label": "PF2E.Skill.Religion",
        "attribute": "wis"
    },
    "society": {
        "label": "PF2E.Skill.Society",
        "attribute": "int"
    },
    "stealth": {
        "label": "PF2E.Skill.Stealth",
        "attribute": "dex"
    },
    "survival": {
        "label": "PF2E.Skill.Survival",
        "attribute": "wis"
    },
    "thievery": {
        "label": "PF2E.Skill.Thievery",
        "attribute": "dex"
    }
}
dslogget commented 1 month ago

Closing for now