search

ironmonk88 / monks-tokenbar

GNU General Public License v3.0
48 stars 46 forks source link

Dice so Nice + Monk's Token Bar - Public Rolls not working in 12.02 (fine in 12.01) #519

Closed matt-duffy closed 2 days ago

matt-duffy commented 1 month ago

Describe the bug If I request a roll using dice so nice and monk's token bar 12.02 as a public roll, the 3d dice are never rolled and the result is not shown unless I (GM) click on the elipsis.

I have tested this with only dice so nice 5.0.5 and Monk's TokenBar 12.02 running and always get the same result. If I downgrade to 12.01 then it all works as expected, the 3 dice is rolled and the result is displayed.

To Reproduce Steps to reproduce the behavior:

  1. Request a roll with Roll Mode "Public Roll", click the Request button
  2. User rolls from the chat card

Expected behavior

  1. 3d dice are rolled
  2. The result is automatically shown

Screenshots GM Requests Roll:

https://github.com/user-attachments/assets/54bd21bd-9c12-41b2-b38a-b5bcc151e8f9

Player Rolls (no dice roll):

https://github.com/user-attachments/assets/9bdb6b35-4c77-4d3e-a45e-d1cc94d61f54

GM has to click to show it:

https://github.com/user-attachments/assets/cb4cecbd-75ce-45fb-9cdd-66125a3bdd16

Please complete as much of the following information as possible:

Additional context I did note that it looked like this issue had a fix in the last release, perhaps this caused it?

https://github.com/ironmonk88/monks-tokenbar/issues/494

Vagabondluc commented 4 days ago

I have this issue since im in v12 (end of june).

I thought at first it was midi-qol. But after playing some sessions without midi-qol, monk token bar was my second guess.

I dont know if it related to this issue, but rolls dont even seem to work after a while.

It super hard to diagnose because the issue is intermittent.

Anyways, monk token bar is disabled in my world right now and i dont have thoses issues anymore.

But i really miss monk token bar.

ironmonk88 commented 2 days ago

Fixed in the latest version