search

ironmonk88 / monks-tokenbar

GNU General Public License v3.0
48 stars 46 forks source link

[BUG] Errors in console since last update #534

Closed CaosFR closed 8 hours ago

CaosFR commented 12 hours ago

Describe the bug A have few error in the console since last update of your module

The first error is the same of this "https://github.com/ironmonk88/monks-tokenbar/issues/533" but not the others

To Reproduce Just update your module and lunch a world

Expected behavior I will reply the concrete consequences of its bugs (not yet verified). This is to inform you of the errors caused by the update.

Screenshots image image

Please complete as much of the following information as possible:

CaosFR commented 8 hours ago

Update : The bar is unusable, there are no buttons, and its behavior is erratic (e.g., it won't exit combat mode).

ironmonk88 commented 8 hours ago

Duplicate of #533 You need to update D&D

CaosFR commented 8 hours ago

As I said, I won't be updating Foundry for the time being. Many like me will wait until the modules are compatibles.

Please mention in your module manifest that this is only for v4, this will be a blessing for many.

Crowguard commented 7 hours ago

@CaosFR It was not intended to be a 4.x only update, but just ended up turning into one due to whatever changes were made to make it compatible with D&D's 4.x happening to break Tokenbar in previous D&D versions. Unfortunately, Foundry not allowing multiple versions of a system to be installed makes it hard to test backwards compatibly with modules.

Blame this on D&D 5e introducing breaking changes without caring about modules or providing any shim methods.