search

ironport / shrapnel

Shrapnel is a scalable, high-performance cooperative threading library for Python.
Other
219 stars 34 forks source link

All the version strings refer to perforce revision strings removed #53

Closed atykhonov closed 10 years ago

atykhonov commented 10 years ago

All the version strings refer to perforce revision strings removed as was reported in issues #40. Also surplus white spaces has been removed.

samrushing commented 10 years ago

The only reason I didn't do this before is because sometimes code will use the version string for stuff like reporting a version number in a protocol implementation. Did you make sure none of them were used anywhere?

atykhonov commented 10 years ago

I just grep the code by __version__ and see that

-- I see it in coro/clocks/tsc_time.c. As I understand this file generates from tsc_time.pyx file. So as I removed this variable from tsc_time.pyx then __version__ will not be generated in tsc_time.c anymore -- I see it in ./old/ldap/ldapurl.py and I leave it as is because there is concrete number: '0.5.2' -- I sse it in ./coro/http/server.py and it uses within this file so I left it as is

So, seems everything is fine

atykhonov commented 10 years ago

A version number for protocol is declared separately in protocol_version variable as I see in coro/ssh/transport/transport.py file

atykhonov commented 10 years ago

There is also ldap_protocol_version declared in coro/ldap/client.py. And these versions indeed uses within a code.

markpeek commented 10 years ago

Merged. Thanks for the commit and apologies for not merging sooner.