Over the holidays I set up Home Assistant and then stumbled over this nice project.
When looking into the code I noticed a few inconsistencies and also that several of the Python "conventions" (PEP8, camel case and so on) that I'm familiar with are not strictly followed.. ;-D
I did put in the effort to do some refactoring.
I can not with 100% certainty say that nothing broke - but I'm running my modified code on three different Raspberry Pi's and it appears to be sending the exact same data.
@ironsheep would you even consider merging this (either as one big commit - or split into individual blocks of changes)?
Line 1000 contains a change that turns a problem with accessing /dev/vcio from a crash into a warning (see also: #94 + #98).
frennkie
commented
4 months ago
Over the holidays I set up Home Assistant and then stumbled over this nice project. When looking into the code I noticed a few inconsistencies and also that several of the Python "conventions" (PEP8, camel case and so on) that I'm familiar with are not strictly followed.. ;-D
I did put in the effort to do some refactoring. I can not with 100% certainty say that nothing broke - but I'm running my modified code on three different Raspberry Pi's and it appears to be sending the exact same data.
@ironsheep would you even consider merging this (either as one big commit - or split into individual blocks of changes)?
Line 1000 contains a change that turns a problem with accessing
/dev/vciofrom a crash into a warning (see also: #94 + #98).