search

ironsheep / RPi-Reporter-MQTT2HA-Daemon

Linux service to collect and transfer Raspberry Pi data via MQTT to Home Assistant (for RPi Monitoring)
GNU General Public License v3.0
442 stars 62 forks source link

Fix broken command_base_topic #86

Closed hobbypunk90 closed 1 year ago

ironsheep commented 1 year ago

Marcel, did you see that further down in the script the base topic is being set? There are two of them now. The later in time is the one that actually takes effect.

For me the whole system is running correctly did you see a case where it is not?

hobbypunk90 commented 1 year ago

I'm only on my mobile at the moment, but I searched on master, "command_base_topic" showed up for 4 times, it's set in 176 und used little way down. command_base_topic is set to a wrong value, something with "{not-set}". In 1.8.0 commands worked on my machine, 1.8.1 commands stopped working 🙈

ironsheep commented 1 year ago

OK, looking into this. My testing didn't show the problem, so re-testing and will get a fix in place yet today!

ironsheep commented 1 year ago

Marcel, I chose a different approach for repairing this. Thank you for reporting the break so quickly! It all should be working once again. This also gave me a chance to fix the LWT offline/online status transition reporting!

This all appears in v1.8.2 and later