ironsmile / euterpe

Self-hosted music streaming server 🎶 with RESTful API and Web interface. Think of it as your very own Spotify! ☁️🎧
https://listen-to-euterpe.eu
GNU General Public License v3.0
534 stars 43 forks source link

Allow building on OpenBSD #36

Closed ledeuns closed 2 years ago

ironsmile commented 2 years ago

Thank you for the PR and for spotting the problem. I've fixed the Euterpe side with c6b143b just moments ago. Explicitly listing all supported operating systems is not really convenient as it turns out.

And for the mattn/go-sqlite3 side of the problem we should make sure any required changes are accepted in there. Once they are I will vendor them in Euterpe. I am slightly surprised that it does not build for OpenBSD. I don't have access to an installation at the moment but will probably be able to spin up a virtual machine in the next few days.

ledeuns commented 2 years ago

Thank you. I opened a PR to mattn/go-sqlite3

ledeuns commented 2 years ago

https://github.com/mattn/go-sqlite3/pull/976 has been commited :)

ironsmile commented 2 years ago

I've created the update-go-sqlite3-to-latest-master branch and will se how it goes. If no problems are detected will probably merge it. I am slightly more cautious as this version of the go-sqlite hasn't been tagged yet and includes quite a lot of changes.

ledeuns commented 2 years ago

Thank you, it builds and runs fine here (openbsd -current)

ironsmile commented 2 years ago

mattn has tagged go-sqlite version which includes your changes and they are now used by the Euterpe's master branch. So I am closing this PR. Thank you again for initiating this improvement.