search

ironstar-io / tokaido

Zero-conf Drupal Local Development Environments with Docker
https://tokaido.io
BSD 3-Clause "New" or "Revised" License
57 stars 10 forks source link

fix issues handling uppercase project names #183

Closed ironmike-au closed 5 years ago

ironmike-au commented 5 years ago

fixes #181

ironmike-au commented 5 years ago

Looks good, I definitely should have been more careful in the first place. The only thing I'd request and possibly a change on is if any other characters could possibly break things as a project name? !@#$%^&* etc. some of which as reserved by the OS, or have special meaning in shell, which could be bad. Whitespace also falls into this category.

I think there's already a slugify library included? Otherwise there's definitely a golang one around.

Long term we need to sit down and see if what docker actually does with names is documented anywhere. So far it seems a bit arbitrary, and I'm not sure if slugifying would result in more breakage, not less.

For now I'll merge as there's limited time this month to put in a proper fix :(