search

ironstar-io / tokaido

Zero-conf Drupal Local Development Environments with Docker
https://tokaido.io
BSD 3-Clause "New" or "Revised" License
57 stars 10 forks source link

Proposal: Stop using the proxy service and just use valid SSL in haproxy #231

Closed ironmike-au closed 4 years ago

ironmike-au commented 4 years ago

Client feedback has suggested that the proxy service (local.tokaido.io) and use a valid SSL on haproxy. The dynamic port number is not as much of a concern as we originally expected.

ironmike-au commented 4 years ago

Way back when we first started Tokaido, one of the 'problems' we wanted to fix was that each time you started a docker project, you got a different set up dynamic ports. The proxy service, which runs out of ~/.tok/proxy was designed to address this by offering users a fixed port (5154) that enabled them to reference their project by name and a static port.

In practice, nobody really seemed to mind having a dynamic port since they just used tok open anyway, and weren't really observing/using the fixed-port URL.

Meanwhile, the proxy service that listens on port 5154 has caused quite a bit of flakiness in the project.

As such, PR #234 takes the first steps towards removing the proxy alltogether (which we will do from 1.14) and stops referencing it when tok open is called. Instead, tok open now opens the local haproxy container (where one exists per-project/environment) using the same trusted TLS cert, so the behaviour is pretty much the same, just with less bugs !