Check tls handshake and TLS 1.0, 1.1 or 1.2 connections

irontec / sngrep

Ncurses SIP Messages flow viewer

GNU General Public License v3.0

1.02k stars 187 forks source link

Check tls handshake and TLS 1.0, 1.1 or 1.2 connections #394

Closed Ozzyboshi closed 2 years ago

Ozzyboshi commented 2 years ago

Maybe this fixes #390 ?

Kaian commented 2 years ago

Hi!

Thanks for the PR.

Wouldn't this completely remove existing SSLv2 support?

Regards

Ozzyboshi commented 2 years ago

Hi!

Thanks for the PR.

Wouldn't this completely remove existing SSLv2 support?

Regards

Honestly I was trying to make it work like openssl sngrep version (which doesnt crash on my setup). If you look at this we have the same function but whithout this checks, why are they missing? Is it normal?

https://github.com/irontec/sngrep/blob/7ed9942c859bab13222d86b4d0fdd370c94664a3/src/capture_openssl.c#L459

Kaian commented 2 years ago

Hi @Ozzyboshi !

Thas a good point :laughing:

Well, I don't actually get why that check is present but I prefer both SSL code to be most similiar so I'm merging this.

Thanks a lot for the contribution!!