search

ironthree / dxr

Declarative XML-RPC in Rust
Apache License 2.0
17 stars 8 forks source link

unescaped field ident for TryFromValue & TryToValue #18

Closed yasamoka closed 10 months ago

yasamoka commented 10 months ago

This allows escaped fields such as r#type to be converted properly.

I also added some test cases to cover missing fields in general as well as escaped fields in both params and responses.

Thank you very much!

decathorpe commented 10 months ago

Looks good to me at first glance, thank you! I'll let the CI run and take a closer look at the code and new test code later.

decathorpe commented 10 months ago

Sorry for the late response, I caught covid two weeks ago and am only now getting back into work. The changes look good to me, and thank you for expanding the tests to cover the new feature. I'll publish a new release soon.

yasamoka commented 10 months ago

Sorry for the late response, I caught covid two weeks ago and am only now getting back into work. The changes look good to me, and thank you for expanding the tests to cover the new feature. I'll publish a new release soon.

No worries, there was no rush. Hope you're doing better now. I had tried doing work back when I had caught the virus early 2022 and crashed very hard, yet my case was mild, so I totally understand.

Thank you again!