Parse scalar string without type indication

ironthree / dxr

Declarative XML-RPC in Rust

Apache License 2.0

17 stars 8 forks source link

Parse scalar string without type indication #8

Closed bahlo closed 1 year ago

bahlo commented 1 year ago

This manual deserialization is necessary to support scalar values without a type element, e.g. <value>foo</value> instead of <value><string>foo</string></value>.

See spec: http://xmlrpc.com/spec.md#scalar-values

Closes #7

decathorpe commented 1 year ago

Awesome, that was quick! Looks good at first glance, I'll review (and probably merge) later today, since the CI is already happy.

decathorpe commented 1 year ago

Thanks a lot, looks good to me. I added some minor changes on top and merged the PR.

I'm still planning for some changes to dxr before I release v0.6.0, are you waiting for a stable release that has this fix, or can it wait? Just so I can prioritize what I'm working on.

bahlo commented 1 year ago

Thanks for merging so quickly, now I can continue with my project 😍

No rush with the release, I‘m pinning a commit from main for the time being ✌🏻