search

irossimoline / angular4-material-table

Angular 4 table based on @angular/cdk table structure, to allow row insertion, edition, validation and deletion.
MIT License
55 stars 25 forks source link

Enabled strictNullChecks. Note: has breaking changes #18

Open hossameldeen opened 6 years ago

hossameldeen commented 6 years ago

As described in #17 , I'm opening this PR just in case you want to check out the solution. But I'm neutral towards merging it; it provides compile-time check for something we're kind-of sure of, but, unfortunately, it breaks backward compatibility.

Sorry for opening it as PR, but I want to delete my fork and want to keep the project's knowledge in one place: your repo, if you don't mind.

Mostly expecting the PR to be closed/rejected.

Thanks again!

irossimoline commented 6 years ago

Hi @hossameldeen, have you checked the comments?

hossameldeen commented 6 years ago

Yup, long time ago, and replied to them too :-)

In case you can't see them, here's the first reply, and the the other one. Please, tell me if there are any comments I've missed.

irossimoline commented 6 years ago

My bad, the comment has been pending to send for weeks, here it is.

Thank you @hossameldeen.