search

irossimoline / angular4-material-table

Angular 4 table based on @angular/cdk table structure, to allow row insertion, edition, validation and deletion.
MIT License
55 stars 25 forks source link

Conflict with rendere 3 in node_modules #31

Open lakinduakash opened 5 years ago

lakinduakash commented 5 years ago

I'm getting error when I run my project. Currently my angular version is 7.

ERROR in node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'.
n
ode_modules/angular4-material-table/node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'.

However after I deleting node_modules folder inside angular4-material-table folder which is in project's node_module, I could run without problem.

irossimoline commented 5 years ago

Hi @lakinduakash , I think it's a library dependency issue, so no extra action required but to reinstall it.

If you have an additional comment about this, please feel free to ping me.

nolafs commented 5 years ago

I am having the same issue when compiling the project.

ERROR in node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'. node_modules/angular4-material-table/node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'.

Any ideas.

Cheers Olaf

nolafs commented 5 years ago

When deleting the node_module inside angular4-material-table package, it compiles fine. The conflict occurs with my version of angular ahead. It tried fixing it by setting the resolution but not much luck with that. Also adding the path to the tsconfig fails to work.

Perhaps if you add the following line to the package.json will fix it: "peerDependencies": { "@angular/core": ">=6.0.0 <8.0.0" },