search

irossimoline / angular4-material-table

Angular 4 table based on @angular/cdk table structure, to allow row insertion, edition, validation and deletion.
MIT License
55 stars 25 forks source link

Upgrade to angular 7 to angular 8 #33

Closed eltonhp closed 5 years ago

eltonhp commented 5 years ago

Hello, I made the upgrade angular 7 to angular 8 on my project. And the error is occurring when the AOT compile at the production mode:

ERROR in ..\angular4-material-table\src\app.module.ts(4,2): Error during template compile of 'AppModule' Function calls are not supported in decorators but 'ɵmakeDecorator' was called in 'NgModule' 'NgModule' calls 'ɵmakeDecorator'.

Please, can you help?

blavenie commented 5 years ago

With Angular 8 i have another error : 

  Type '() => import("./node_modules/@angular/forms/forms").FormGroup' is not assignable to type '() => import("./node_modules/angular4-material-table/node_modules/@angular/forms/src/model").FormGroup'.

I think a simple recompilation with this PR will fix this.

irossimoline commented 5 years ago

Merged and created v0.8.0 with it. Thank you @blavenie for your help!

rsteaburdea commented 5 years ago

Hello.

Is npm linked automatically to the latest version on github or should I do something different than npm install --save angular4-material-table?