search

irplus-remote / irplus-codes.github.io

Code updates for irplus
76 stars 47 forks source link

LIRC parser needs some work (e.g. support other protocols like Samsung-36) #346

Open e2thenegpii opened 6 years ago

e2thenegpii commented 6 years ago

I've got a Samsung BD-P1600. Attached is my lirc config file for it. IRLib2 recognizes the protocol from the remote as Samsung36 however the same receiver doesn't detect the protocol coming from irplus with the above imported lirc file. The only difference is irplus seems to omit a needed pulse before the payload. That pulse is configured by the pre directive.

Please either add support for the LIRC pre directive or LIRC raw_codes or recommend another way to output the below signal. The LIRC Raw format is below for the power button. Please note there is a "500 4500" pulse about halfway through the waveform. The irplus output is identical except noted "500 4500" pulse is omitted.

4500 4500 500 500 500 500 500 500 500 500 500 500 500 1500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 4500 500 1500 500 1500 500 1500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 500 1500 500 1500 500 1500 500 1500 500 1500 500 1500 500 1500 500 1500 500 7000

Thank you.

irplus-remote commented 6 years ago

Hi import from lirc only works for NEC1 Hex and RAW at the moment, so the import of your lirc-file is not working. That i can confirm. (The lirc parser needs a lot of work). The code is basically the one shown here (see the JS code) https://irplus-remote.github.io/converter/lirc.html

I suggest to use the templates shown under
image inside the app list

If you want to output the raw code like shown you can just use the raw protocol , like shown in AK59-00149A-00167A-BluRay, this will output as

protocol = Samsung36, device = 32, subdevice = 0, obc = 0, misc = E=7

image

irplus-remote commented 6 years ago

By the way, you can use irScrutinizer to import a lirc conf, and export it to irplus format (in pronto) this will result in working config in 99% of the cases :)

e2thenegpii commented 6 years ago

Thanks, I was able to get it working exporting it to the IRPlus format via IRScrutinizer. I'll submit a pull request once I've finished the xml layout.