irreducible-representations / irrep

GNU General Public License v3.0
62 stars 31 forks source link

irreptables is not upgrading #81

Closed bmondal94 closed 4 months ago

bmondal94 commented 4 months ago

Dear @stepan-tsirkin @MIraola ,

Sorry...

irreptables is still not upgrading to latest version when installing irrep. Earlier I re-installed irreptables with git clone. So, I missed to catch the problem then. Tried a few options.

So far, cloning irrep locally, going into irreptables and then using pip install . is working.

Could not come up with any other solution.

bmondal94 commented 4 months ago

@stepan-tsirkin Ha Ha...

bmondal94 commented 4 months ago

Minor: The url in irreptables setup.py can be updated to latest url.

stepan-tsirkin commented 4 months ago

@bmondal94 , you are right, new irreptables is not released. We did not update it for a long time, and I forgot that @MIraola did not have permissions to upload that package to pypi.

@MIraola , I invited you to that repo on pypi, so please upload irreptables there.

MIraola commented 4 months ago

Hi @bmondal94 and @stepan-tsirkin ,

thank you for the invitation to the pypi repository. I have updated irreptables there. I have installed irrep via pip install irrep in a new environment created from scratch and it correctly installed irreptables=1.1.0 (the version I had just uploaded to pypi). So, it seems it is fixed.

MIraola commented 4 months ago

Let me know if we can close the comment, please.

bmondal94 commented 4 months ago

Hi @MIraola

Thanks. Perfect.

Just a reminder in case you have not implemented it yet, before the next irrep release it would be great if you could add irreptables>=1.1.0 version requirement in irrep setup.py, otherwise irrep upgrading would ignore upgrading already installed old irreptables.