search

irritanterik / homey-http-request-actions

HTTP request actions for flows on Homey by Athom
16 stars 14 forks source link

added POST XML action card #10

Closed RobertoPeters closed 7 years ago

RobertoPeters commented 7 years ago

Once the XML has been entered, it works. However there are two issues (probably caused by one thing)

  1. you cannot paste an xml into the data
  2. rebooting removes the XML tag Probably due to the format. If you don't want to perform this pull request, then please advise me where I need to change this.
irritanterik commented 7 years ago

Thank you for your contribution! Can you extend readme.md with this card and bump version number in package.json? And will use of json to xml converion resolve both issues? The xml2js package allready used with this app supports bi-directional conversions:

var builder = new xml2js.Builder();
var xml = builder.buildObject(obj);

If not, please request athom to support 'plain text' input fields on flow cards.

RobertoPeters commented 7 years ago

I updated the readme and app version, but somehow I cannot do a new pull request. But actually, you decide what the new version number would need to be. And as for the xml2js builder. Actually, I just want text and not xml. Most cards have this, but I just don't get it how its done. I hope you can do this.

irritanterik commented 7 years ago

I added support for POST XML with commit 5109ab0 . Reboot keeps the typed XML now. I will push this to the app store in a few days.

irritanterik commented 7 years ago

Thanks for your contribution!