"window dehilight" signal not used

irssi-import / bugs.irssi.org

bugs.irssi.org archive

https://github.com/irssi/irssi/issues

0 stars 0 forks source link

"window dehilight" signal not used #658

Open irssibot opened 15 years ago

irssibot commented 15 years ago

- - Issue #658 opened by @lack
In src/fe-common/core/window-activity.c, function sig_dehilight_window(), signal "window dehilight" is not called. To do so, add on line 121:

signal_emit("window dehilight", 1, window);

irssibot commented 15 years ago

- - Comment 1010 by @lack

Also, since on line 44 comparison is made in window_activity() whether data_level is 0, signal "window hilight" is emitted even when going from a higher level to a lower. So if the proposed line is added, "window hilight" will be emitted at the same time "window dehilight" is.

irssibot commented 15 years ago

- - Comment 1011 by @lack

No, hold on. This effects in windows not being dehilighted properly in the status bar [Act: ] field.

The main issue stands, though: "window dehilight" isn't used anywhere.