irssi-proxy breaks RFC - Githubissues

irssi-import / bugs.irssi.org

bugs.irssi.org archive

https://github.com/irssi/irssi/issues

0 stars 0 forks source link

irssi-proxy breaks RFC #780

Closed irssibot closed 8 years ago

irssibot commented 13 years ago

- - Issue #780 opened by @Dataforce

Recently when trying to use irssi-proxy with an RFC 1459 compliant irc parser, the lines output to the parser from irssi-proxy were considered invalid.

Specifically, irssi-proxy incorrectly only uses "\n" line terminators rather than the "\r\n" terminators specified by the protocol - http://www.irchelp.org/irchelp/rfc/chapter2.html#c2_3_1

irssibot commented 13 years ago

- - Comment 1276 by @coekie

I'm curious, what is the "RFC 1459 compliant irc parser" you are using?

irssibot commented 13 years ago

- - Comment 1280 by @Dataforce

Hi,

I was using one of the nightly builds of a client called DMDirc, which expected "\r\n" when parsing the lines, but I have made a change to allow it to work with just "\n" but I figured you would want to know about this incase other clients have problems dealing with irssi-proxy.

irssibot commented 10 years ago

- - Comment 1673 by @Silentium

I experienced this bug as well, as Quassel choked on the non-conforming line breaks. I was able to fix it locally by replacing all occurrences of \n with \r\n in the proxy source files:

cd src/irc/proxy/
sed 's/\\n/\\r\\n/g' -i dump.c
sed 's/\\n/\\r\\n/g' -i listen.c

irssibot commented 8 years ago

- - Closed by @Geert

https://github.com/irssi/irssi/pull/269/files