usermode is never NULL

[irssibot]

• • • Issue #919 opened by @zeebaasheDi9

irssi sends MODE %s %s to server even if usermode = ""; in config. This could lead to nickname or activity exposure if irssi used behind bouncer.

quickfix attached

[irssibot]

• • • Attachment 309 by @zeebaasheDi9

usermode.patch

diff -rupN irssi-0.8.16-rc1/src/irc/core/irc-servers.c irssi-0.8.16-rc1-new/src/irc/core/irc-servers.c
--- irssi-0.8.16-rc1/src/irc/core/irc-servers.c 2014-05-20 09:11:28.330063178 +0400
+++ irssi-0.8.16-rc1-new/src/irc/core/irc-servers.c 2014-05-20 09:54:29.032831188 +0400
@@ -552,7 +552,7 @@ static void event_connected(IRC_SERVER_R
    g_get_current_time(&now);
    memcpy(&server->wait_cmd, &now, sizeof(GTimeVal));

-   if (server->connrec->usermode != NULL) {
+   if (strcmp(server->connrec->usermode,"") != 0) {
        /* Send the user mode, before the autosendcmd.
         * Do not pass this through cmd_mode because it
         * is not known whether the resulting MODE message

[irssibot]

• • • Closed by @Geert

See https://github.com/irssi/irssi/pull/315