irtazahashmi / pytspl

A Python library for Topological Signal Processing and Learning.
MIT License
4 stars 0 forks source link

lap**i should be "corrected" #52

Open cookbook-ms opened 2 months ago

cookbook-ms commented 2 months ago

https://github.com/irtazahashmi/pytspl/blob/3c06f415cb843f6fbaee2270fd3a938d56c46684/pytspl/filters/ls_filter_design.py#L67C2-L67C54

The current implementation of general filters is missing and is correct only when the Laplacian matrix is sparse. If the matrix is not sparse, line 67 is computing the elementwise power of the matrix, not matrix power. This should be corrected.

This is assigned for future issue reference.