Fix Travis CI build - Githubissues

irtimmer / tpm2-pk11

[DEPRECATED] PKCS#11 Module for TPM 2.0

BSD 2-Clause "Simplified" License

68 stars 24 forks source link

Fix Travis CI build #81

Closed diabonas closed 6 years ago

diabonas commented 6 years ago

Currently, there are two problems with the continuous integration that are fixed by this pull request:

On the tpm2-tools master branch, some option names have changed. In the tests for tpm2-pk11, the old option names are still used, causing failed checks. The first commit updates the option names.
tpm2-tools does not compile with clang 3.8 due to a "missing field initializer" warning that is treated as an error by -Werror. The second commit disables this warning for the tpm2-tools build. A better solution would be to update clang to a more recent version that does not show this warning any more, but that seems to be more difficult with Travis.

diabonas commented 6 years ago

Oops, unfortunately the second commit does not seem to have had the desired effect. I will investigate other options to achieve a successful build with clang (it is quite difficult to test this as I do not have Travis available locally).

diabonas commented 6 years ago

So it turns out that for clang, -Wno-missing-field-initializers needs to be specified after -Wextra, otherwise the former option gets overwritten again. I have fixed the second commit so that tpm2-tools can now be built successfully with clang.

In its current state, the pull request successfully fixes the build environment. Note that the build still fails as the current tpm2-pk11 code base does not compile with tpm2-tss and tpm2-abrmd 2.0. To fix this and have a successful CI build, https://github.com/irtimmer/tpm2-pk11/pull/79 needs to be applied in addition to this pull request.