irtlab / rtptools

RTP Tools
http://www.cs.columbia.edu/irt/software/rtptools/
Other
166 stars 64 forks source link

OpenBSD port #51

Open janstary opened 6 years ago

janstary commented 6 years ago

Now that the license is accaptable, prepare an OpenBSD port of RTP tools.

janstary commented 6 years ago

I pushed the port upstream, but the OpenBSD ports tree is locked now for the 6.3 release. Will get back to it once 6.3 is out.

mcd500 commented 6 years ago

It would be good to heve the estimated date if you could predict when it will be unlocked for the future OpenBSD, then others could collaborate and adopt on the time-line because not all knows the schedules to satisfy your intention.

janstary commented 6 years ago

The new version is usually out by the start of May.

mcd500 commented 6 years ago

Thank you for sharing the valuable information. It makes people to help coordinate have the rtptools easier for OpenBSD release.

namtsui commented 5 years ago

Hello. I am posting to share my interest in an OpenBSD port for rtptools. I see that a work-in-progress port was started by @janstary. Please let me know if I can assist with testing or porting. I am also glad to hear about the new license.

mcd500 commented 5 years ago

Hi @namtsui, thank you for your interest. The original license of the rtptools used to be mentioning that the permission to use, copy, modify was granted for research and educational purpose. The license was changed to Modified 3-Clause BSD License from version 1.22. The current license should be ok to be in any of openbsd distribution. I am not OpenBSD expert and I appreciate any kind of feedback of building and running the latest rtptools.

namtsui commented 5 years ago

The license was changed to Modified 3-Clause BSD License from version 1.22. The current license should be ok to be in any of openbsd distribution.

I noticed that notify.h and notify.c are copyright Sun Microsystems and AT&T Bell Laboratories.

/*
stripped-down version of <xview/notify.h>

(c) Copyright 1989, 1990, 1991 Sun Microsystems, Inc. Sun design
patents pending in the U.S. and foreign countries. OPEN LOOK is
a trademark of USL. Used by written permission of the owners.
*/
/*
notify  --  primitive notification service implementing a subset of the SunOS
            (sunview/XView) notifier.

Copyright 1993 by AT&T Bell Laboratories; all rights reserved
*/

Does this conflict with the BSD 3-clause license that rtptools is released under? I wanted to get your input on it first before submitting the port to OpenBSD.

For context, here is what OpenBSD says about licensing.

# Licensing:  This determines what we can distribute.
# When you determine the license type, make sure to look at ALL distfiles.
# Every distfile can have a different license.  The PERMIT_* values are
# determined by the most restrictive license.  If you have two licenses
# that are in conflict, set PERMIT_* based on the most restrictive one.
# Make SURE you get these values right.

# Put a comment there to state what's going on.
# Can be as brief as `BSD' or `GPLv2+', but it'd better be easy to check,
# if someone wants to double-check licensing.
# For GPL, the applicable versions must be included (e.g. v2+, v2 only, v3+).
# If all PERMIT_* are Yes, just setting 'PERMIT_PACKAGE_CDROM=Yes' is enough.
#PERMIT_PACKAGE_CDROM = Yes | Reason if No
#PERMIT_PACKAGE_FTP =   Yes | Reason if No
#PERMIT_DISTFILES_FTP = Yes | Reason if No

Also, on your download page the Copyright statement should be fixed.

namtsui commented 5 years ago

I have just discovered discussions here regarding licensing https://github.com/cu-irt/rtptools/pull/18

This answers my question in that there is no conflict, since BSD 3-clause only touches files that belong to rtptools.

The license only touches the files that are belong to us. There are others, under various licenses:

  • hsearch.[ch] (c) UCB / Margo Seltzer
  • multimer.[ch] (c) UCB / Bolt Beranek and Newton Inc
  • notify.[ch] (c) SunOS / AT&T
  • vat.h UCB / Henning Schulzrinne
  • the auto* tools are GPL, obviously

and the submission from @janstary https://marc.info/?l=openbsd-ports&m=140369592302389&w=2 https://marc.info/?l=openbsd-ports&m=152198740924262&w=2

mcd500 commented 5 years ago

Hi @namtsui, Thank you for searching of licenses discussion on the openbsd-ports mailing list. I have a feeling that the license statement of notify.[ch] might be considered as a conflict from some people. I always had an idea to re-implement the functions used inside notify.[ch] since the declaration in the header and the .c file do not match and not all are used, but never took a check of my time for it. Would you like to start re-implanting?

mcd500 commented 5 years ago

Also, on your download page the Copyright statement should be fixed.

Thank you for spotting it. I will inform to Henning.