search

irtlab / rtptools

RTP Tools
http://www.cs.columbia.edu/irt/software/rtptools/
Other
166 stars 64 forks source link

drop the hsearch(3) replacement #66

Closed janstary closed 6 years ago

janstary commented 6 years ago

We don't need to bring our own hsearch(3) anymore, systems have it nowadays. (And they are newer than our buggy hsearch.c from glibc 2.0 in 1993).

janstary commented 6 years ago

Maybe we could get rid of hsearch altogether: we don't need a full-fledged hash table implementation to remember the SSRCs we have seen and their timestamps.

janstary commented 6 years ago

Hm, we can't simply remove this, because Windows does not have hsearch. So if we want to continue using it, we need to check that the system has it, and bring our own implmementation in case it does not.

Would it be simpler to replace the use of hash tables in rtpplay.c with a simple list, and not deal with hsearch at all?

janstary commented 6 years ago

See https://github.com/columbia-irt/rtptools/issues/73 instead