search

irufus / gdax-java

Java based wrapper for Coinbase Pro (Formerly known as GDAX API and Coinbase Exchange API)
MIT License
177 stars 131 forks source link

Fixes for listing and deposits from payment methods, and placing limit orders #20

Closed duanemay closed 6 years ago

duanemay commented 6 years ago

Fixes issues with:

Also adds a number of toString methods

irufus commented 6 years ago
  1. I'm not sure if anyone requested a toString feature. Nevertheless, it would be best to use a JSON builder like Gson.
  2. I don't understand the changes to member variables to be only of a single type and not an array of the same type.
  3. If there are issues with payment requests please create an issue for them.
duanemay commented 6 years ago

  1. These are for the most part standard toString methods that IDEA generates. It is helpful during development.

  2. I created new issue #21 explaining the problems I was seeing on PaymentService.getPaymentTypes and PaymentService.getCoinbaseAccounts Which involved changing some arrays to non-arrays and some non-arrays to arrays.

3a. I also created a feature request #22 to add fields to Limit

3b. I updated the issues #1 and #6 which should also be fixed by this PR.