search

irufus / gdax-java

Java based wrapper for Coinbase Pro (Formerly known as GDAX API and Coinbase Exchange API)
MIT License
177 stars 131 forks source link

Please make additional data on Limits available #22

Closed duanemay closed 6 years ago

duanemay commented 6 years ago

The GET /payment-methods call is returning additional data that is not captured in the Limit object

For Example: "limits": { "type": "fiat_account", "name": "Coinbase Account", "sell": [

"limits": { "type": "bank", "name": "Bank Account", "buy": [

I created a fix for this in PR #20 commit 1da25565514748d076b74b899ff4fa36823a13f9

robevansuk commented 6 years ago

feel free to add missing data fields and make a pull request - this is not something I've wanted/needed in the past so it probably got missed out. Otherwise I'll stick it on the list of things to look at (later)!

duanemay commented 6 years ago

They are already in PR #20 commit 1da2556. I think it was closed without merge

robevansuk commented 6 years ago

+1

irufus commented 6 years ago

type and limit are already captured in the PaymentType. When testing the additional fields against the sandbox no data was returned under Limit.

I was able to confirm all of this using the PaymentTests::hasAvailablePayments() test.