search

irufus / gdax-java

Java based wrapper for Coinbase Pro (Formerly known as GDAX API and Coinbase Exchange API)
MIT License
177 stars 131 forks source link

Update to constructor based Injection for all services #38

Closed irufus closed 3 years ago

irufus commented 6 years ago

https://stackoverflow.com/questions/21218868/explain-why-constructor-inject-is-better-than-other-options

` //current injection (i.e. Withdrawals Service) @Autowired GdaxExchange gdaxExchange;

//Constructor injection method GdaxExchange gdaxExchange; @Inject public WithdrawalService (GdaxExchange gdaxExchange){ ... } `

robevansuk commented 6 years ago

thought Id used constructor injection when I'd put the dependency in. Clearly not. oops. will update in the next couple of weeks. got a scala project to finish first.

irufus commented 6 years ago

No rush. I'm clearing up the issues one by one so we can look at this in the future.

robevansuk commented 6 years ago

I've made amendments over at my own repo which hopefully can be merged in when the orderbook is sorted. Just need to make things a bit more configurable first of all.

gvespucci commented 4 years ago

Hi, is still issue a thing? I'm not able to find an @Autowired - for example - in the repo. Thanks

robevansuk commented 4 years ago

Its fixed on a branch https://github.com/irufus/gdax-java/pull/62/files

robevansuk commented 4 years ago

I'm going to remove the gui and start over - it was nice when it worked but it wasn't very good and I'd like to try building it again in JavaFx

robevansuk commented 3 years ago

This is now done / the spring application removed from the codebase as the gui was not really a part of the library and should ideally be separated out from this codebase.