search

irufus / gdax-java

Java based wrapper for Coinbase Pro (Formerly known as GDAX API and Coinbase Exchange API)
MIT License
177 stars 131 forks source link

These are the changes I made to run your source as part of our microservice #52

Closed markd315 closed 6 years ago

markd315 commented 6 years ago

Lots of the diff is whitespace but some of these endpoints and json were definitely wrong.

robevansuk commented 6 years ago

I'd suggest first of all updating the indentation settings since there are a number of lines affected where no material change has been made and the alignment is all off. This will be a pain for anyone picking up these changes to deal with if one file is 4 spaces and then some are 2. Please amend. I'd also suggest adding some tests for the solution where possible. Will take a proper look later.

irufus commented 6 years ago

@markd315 You also need to add .DS_Store to your git ignore list.