Fixes from before - Githubissues

irufus / gdax-java

Java based wrapper for Coinbase Pro (Formerly known as GDAX API and Coinbase Exchange API)

MIT License

177 stars 131 forks source link

Fixes from before #53

Closed markd315 closed 5 years ago

markd315 commented 5 years ago

...bump?

You requested changes on a different PR and I had to make a new one to fix the formatting properly.

irufus commented 5 years ago

Looks good.

Not completely related but one of the key unit tests that I was running was failing but wasn't due to your changes but it'll need to be addressed outside this PR to ensure that canMakeLimitOrderAndGetTheOrderAndCancelIt still works. I'm making note of this as I will be adding a CONTRIBUTING markdown file that will instruct contributors to utilize unit testing before submitting PR.

irufus commented 5 years ago

Also you forgot to include a class member for NewLimitOrderSingle::product_id. No new PR for that as I can fix this in the main branch.