Full market data support

irufus / gdax-java

Java based wrapper for Coinbase Pro (Formerly known as GDAX API and Coinbase Exchange API)

MIT License

177 stars 131 forks source link

Full market data support #7

Closed irufus closed 6 years ago

robevansuk commented 7 years ago

Think this is added

duanemay commented 6 years ago

I agree. it is there and my app has been using the Top 50 level (but in building my app I tested other levels).

A suggestion would be to pass an enum instead of a string for the level. private static final String BEST_ORDERS = "1"; private static final String TOP_50_ORDERS = "2"; private static final String FULL_ORDERS = "3";

MarketData marketDataOrderBook = marketDataService.getMarketDataOrderBook(product, TOP_50_ORDERS);

robevansuk commented 6 years ago

1 will try and update with sensible constants in the next version. Implementing the level 3 orderbook is taking considerable time on my part due to other commitments but should be available in the next 4-8 weeks with any luck.

irufus commented 6 years ago

Closing it for now. Noted that upvotes will likely come in the future.