search

irungentoo / filter_audio

An easy to use audio filtering library made from webrtc code.
170 stars 86 forks source link

mem overflow bug #44

Open zoff99 opened 4 years ago

zoff99 commented 4 years ago

https://github.com/irungentoo/filter_audio/blob/ada2f4fdc04940cdeee47caffe43add4fa017096/filter_audio.c#L320-L321

memset tries to write twice the bytes of the actual buffer size

A/libc: FORTIFY: memset: prevented 640-byte write into 320-byte buffer

should say:

memset(temp, 0, nsx_samples*sizeof(int16_t));

thanks to @kaefert for helping me find this

zoff99 commented 4 years ago

https://github.com/isotoxin/filter_audio/blob/37e81bcc934d3556ca52e8dfbd0a2396c868a684/filter_audio.c#L331

fixed here

https://github.com/isotoxin/filter_audio/commit/4adf0d2c175040c86f5a757bcffd190db224438d

ghost commented 3 years ago

Will this get merged?