search

iryna-kondr / scikit-llm

Seamlessly integrate LLMs into scikit-learn.
https://beastbyte.ai/
MIT License
3.38k stars 275 forks source link

predict #90

Closed lpfgarcia closed 6 months ago

lpfgarcia commented 7 months ago

ZeroShotGPTClassifier.predict must return an np.array instead of a list.

lpfgarcia commented 7 months ago

https://scikit-learn.org/stable/modules/generated/sklearn.base.BaseEstimator.html

OKUA1 commented 7 months ago

Hi @lpfgarcia,

I agree, It would be better that all of the predictions are numpy arrays. There was a historical reason what it is not, but since v1.0 it should not be applicable anymore.

If you are willing to contribute, you can create a PR with the proposed change.