search

is-consulting / moddingSuite

Wargame modding suite
MIT License
56 stars 24 forks source link

Port to net 5 #37

Closed RemiGC closed 3 years ago

RemiGC commented 3 years ago

This is a port of the app to run on net 5.

I ran the .net upgrade assistant and cleaned up the result. Everything seems ok at first glance.

Let me know what you guys think.

is-consulting commented 3 years ago

Is this fully functional yet? Any concerns with dependencies like ziblib?

RemiGC commented 3 years ago

It's now added as a nuget package. Fonctionalities that use compression via ZlibStream works.

<PackageReference Include="Ionic.Zlib.Core" Version="1.0.0" />

Every function in the app I know works. I don't think I know everything however.

There's debug only exception coming from xml serializers because of settings. You can precompile an additional assembly to speed up xml serializer, if it's not there it fall back to reflection(I think). Never manage to make this works, on either 3.1, 5 or 6 preview. I assume that the speed trade off is ok since it's only for settings.

If you have some tips on creating each files for the test assembly, I can make sure they all run.

RemiGC commented 3 years ago

After some search on google, there's multiple zstream library that works.

https://github.com/haf/DotNetZip.Semverd works as a direct replacement and is newer https://github.com/icsharpcode/SharpZipLib would require some changes however.

What do you think?

RemiGC commented 3 years ago

I change the PR, to make the solution compile both net472 and net5. You can now switch between the two in VS. I added some tests to read data from red dragon & airbattle along a with .runsettings to specify the path to data folder.

is-consulting commented 3 years ago

I dont have the time to check this out right now but I love what you are doing thus Im going to merge the PR. Thanks for the contribution!