search

isDipesh / gnome-shell-extension-sensors

Gnome shell extension: Shows CPU temperature, HDD temperature, voltage and fan RPM
https://motorscript.com/gnome-shell-extension-sensors/
161 stars 153 forks source link

Update for GNOME v3.12 Compatibility #107

Closed jheretic closed 9 years ago

jheretic commented 10 years ago

I'm afraid I'm not terribly familiar with the structuring of GNOME extensions. However, I integrated the fixes suggested by @svu in #104 and it seems to work for me. I was not able to test on previous GNOME versions.

ouchadam commented 10 years ago

:+1: I would also love to see this merged

yanickrochon commented 10 years ago

Just installed this and am running gnome shell 3.12 and the extension is not compatible at the moment. Perhaps do a branch....

warmsun0220 commented 10 years ago

i have test it and it works very well, hope merge it soon!

wbober commented 10 years ago

I've tested it too. Works fine.

adrianbroher commented 10 years ago

Please try out if the changes I pushed recently work out for you.

UshakovVasilii commented 10 years ago

Don't work without ' and \

mijoharas commented 10 years ago

I am currently unable to install from the gnome extensions site should it be working or should I look into it?

adrianbroher commented 9 years ago

Both issues should be addressed now.

The invalid dbus interface should be fixed with the commits e6d4db and e0a6c5.

The support for Gnome Shell 3.12 was added with commit b17877.

I assume this issue can be closed now. If the problems still persist please open a new issue.

@mijoharas You can follow #102 if you want to.

mijoharas commented 9 years ago

Looks like you're supporting 3.16 as well. Thanks @adrianbroher