isDipesh / gnome-shell-extension-sensors

Gnome shell extension: Shows CPU temperature, HDD temperature, voltage and fan RPM
https://motorscript.com/gnome-shell-extension-sensors/
161 stars 153 forks source link

Sensors should not show "NaN°C" #81

Closed Mno-hime closed 11 years ago

Mno-hime commented 11 years ago

If hddtemp is installed, it finds several devices which does not report temperature but says "not available" instead:

~ $ hddtemp /dev/sda: TOSHIBA XXXXXXXXX: 35°C /dev/sdb: Corsair Flash Voyager: S.M.A.R.T. not available /dev/sdc: Generic-xD/SD/M.S.: S.M.A.R.T. not available

Unfortunately GSE Sensors takes that and then shows "NaN°C" for that device as well as for Average label.

Device which does not report temperature should be omitted, in my opinion.

adrianbroher commented 11 years ago

Thanks for reporting that issue.

Device which does not report temperature should be omitted, in my opinion.

You're right. Unfortunately I don't own any drive without S.M.A.R.T., so your report is just what I needed. Could you please report the exact output of hddtemp when using the C locale (just call LANG=C LC_ALL=C hddtemp)?

Also it would be nice to report the output that is given by hddtemp in daemon mode running LANG=C LC_ALL=C hddtemp -dF and querying the daemon by calling nc 127.0.0.1 7634 on another shell.

Mno-hime commented 11 years ago

Thanks for looking into it.

What about this?

~ $ LANG=C LC_ALL=C hddtemp /dev/sda: TOSHIBA MQ01ABD075: 27 C /dev/sdb: Corsair Flash Voyager: S.M.A.R.T. not available /dev/sdc: Generic-xD/SD/M.S.: S.M.A.R.T. not available

~ $ nc 127.0.0.1 7634 |/dev/sda|TOSHIBA MQ01ABD075|27|C||/dev/sdb|Corsair Flash Voyager|NA|||/dev/sdc|Generic-xD/SD/M.S.|NA||~ $

Just a note: any USB flash disk works this way, no special device necessary.

adrianbroher commented 11 years ago

Seems like @xtranophilist already fixed this two weeks ago with commit 4f6f1c4f. Anyway, thanks to you I fixed another issue about displaying multiple drives vi hddtemp daemon mode. If you want you can test the latest master, by following the manual installation instructions and report back if the latest version fixes the issue for you.

Mno-hime commented 11 years ago

Cool, I verified master and it's fixed for me. Thansk @adrianbroher and @xtranophilist.